spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1132] Persisting Web UI through refacto...
Date Fri, 14 Mar 2014 17:35:25 GMT
Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10618053
  
    --- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
    @@ -49,11 +50,13 @@ private[spark] class CacheManager(blockManager: BlockManager) extends
Logging {
                   try {loading.wait()} catch {case _ : Throwable =>}
                 }
                 logInfo("Finished waiting for %s".format(key))
    -            // See whether someone else has successfully loaded it. The main way this
would fail
    -            // is for the RDD-level cache eviction policy if someone else has loaded
the same RDD
    -            // partition but we didn't want to make space for it. However, that case
is unlikely
    -            // because it's unlikely that two threads would work on the same RDD partition.
One
    -            // downside of the current code is that threads wait serially if this does
happen.
    +            /**
    --- End diff --
    
    super tiny nit (more like trivia): javadoc-style comments are generally only for classes/methods/variables,
technically this should be just "/*"... not really important enough to fix unless you get
the whim


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message