spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1244] Throw exception if map output sta...
Date Sat, 15 Mar 2014 05:48:14 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/147#discussion_r10633644
  
    --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
    @@ -35,13 +35,21 @@ private[spark] case class GetMapOutputStatuses(shuffleId: Int)
       extends MapOutputTrackerMessage
     private[spark] case object StopMapOutputTracker extends MapOutputTrackerMessage
     
    -private[spark] class MapOutputTrackerMasterActor(tracker: MapOutputTrackerMaster)
    +private[spark] class MapOutputTrackerMasterActor(tracker: MapOutputTrackerMaster, conf:
SparkConf)
       extends Actor with Logging {
    +  val maxAkkaFrameSize = conf.getInt("spark.akka.frameSize", 10) * 1024 * 1024 // MB
    --- End diff --
    
    On this one a few suggestions:
    
    1. Have the code in `Executor.scala` do what you are doing here rather than access `akka.remote.netty.tcp.maximum-frame-size`
directly (for consistency).
    2. Rather than hard code "10" here, create a companion object to `AkkaUtils` and give
it a variable with the default frame size. That way we only have to change the constant 10
in one place if we decide to change it.
    
    /cc @kayousterhout


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message