spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacek Laskowski <ja...@japila.pl>
Subject Re: [STREAMING] DStreamClosureSuite.scala with { return; ssc.sparkContext.emptyRDD[Int] } Why?!
Date Tue, 05 Apr 2016 23:48:13 GMT
Hi Ted,

Yeah, I saw the line, but forgot it's a test that may have been
testing that closures should not have return. More clear now. Thanks!

Pozdrawiam,
Jacek Laskowski
----
https://medium.com/@jaceklaskowski/
Mastering Apache Spark http://bit.ly/mastering-apache-spark
Follow me at https://twitter.com/jaceklaskowski


On Tue, Apr 5, 2016 at 6:47 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> The next line should give some clue:
>     expectCorrectException { ssc.transform(Seq(ds), transformF) }
>
> Closure shouldn't include return.
>
> On Tue, Apr 5, 2016 at 3:40 PM, Jacek Laskowski <jacek@japila.pl> wrote:
>>
>> Hi,
>>
>> In
>> https://github.com/apache/spark/blob/master/streaming/src/test/scala/org/apache/spark/streaming/DStreamClosureSuite.scala#L190:
>>
>> { return; ssc.sparkContext.emptyRDD[Int] }
>>
>> What is this return inside for? I don't understand the line and am
>> about to propose a change to remove it.
>>
>> Pozdrawiam,
>> Jacek Laskowski
>> ----
>> https://medium.com/@jaceklaskowski/
>> Mastering Apache Spark http://bit.ly/mastering-apache-spark
>> Follow me at https://twitter.com/jaceklaskowski
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
>> For additional commands, e-mail: dev-help@spark.apache.org
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
For additional commands, e-mail: dev-help@spark.apache.org


Mime
View raw message