spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hyukjin Kwon <gurwls...@gmail.com>
Subject Re: Running lint-java during PR builds?
Date Mon, 21 May 2018 05:09:07 GMT
I would like to revive this proposal. Travis CI. Shall we give this try? I
think it's worth trying it.

2016-11-17 3:50 GMT+08:00 Dongjoon Hyun <dongjoon@apache.org>:

> Hi, Marcelo and Ryan.
>
> That was the main purpose of my proposal about Travis.CI.
> IMO, that is the only way to achieve that without any harmful side-effect
> on Jenkins infra.
>
> Spark is already ready for that. Like AppVoyer, if one of you files an
> INFRA jira issue to enable that, they will turn on that. Then, we can try
> it and see the result. Also, you can turn off easily again if you don't
> want.
>
> Without this, we will consume more community efforts. For example, we
> merged lint-java error fix PR seven hours ago, but the master branch still
> has one lint-java error.
>
> https://travis-ci.org/dongjoon-hyun/spark/jobs/176351319
>
> Actually, I've been monitoring the history here. (It's synced every 30
> minutes.)
>
> https://travis-ci.org/dongjoon-hyun/spark/builds
>
> Could we give a change to this?
>
> Bests,
> Dongjoon.
>
> On 2016-11-15 13:40 (-0800), "Shixiong(Ryan) Zhu" <shixiong@databricks.com>
> wrote:
> > I remember it's because you need to run `mvn install` before running
> > lint-java if the maven cache is empty, and `mvn install` is pretty heavy.
> >
> > On Tue, Nov 15, 2016 at 1:21 PM, Marcelo Vanzin <vanzin@cloudera.com>
> wrote:
> >
> > > Hey all,
> > >
> > > Is there a reason why lint-java is not run during PR builds? I see it
> > > seems to be maven-only, is it really expensive to run after an sbt
> > > build?
> > >
> > > I see a lot of PRs coming in to fix Java style issues, and those all
> > > seem a little unnecessary. Either we're enforcing style checks or
> > > we're not, and right now it seems we aren't.
> > >
> > > --
> > > Marcelo
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>
>

Mime
View raw message