spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sean Owen <>
Subject Re: Review notification bot
Date Wed, 06 Jun 2018 17:33:12 GMT
Certainly I will frequently dig through 'git blame' to figure out who might
be the right reviewer. Maybe that's automatable -- ping the person who last
touched the most lines touched by the PR? There might be some false
positives there. And I suppose the downside is being pinged forever for
some change that just isn't well considered or one of those accidental
100K-line PRs. So maybe some way to decline or silence is important, or
maybe just ping once and leave it. Sure, a bot that just adds a "Would @foo
like to review?" comment on Github? Sure seems worth trying if someone is
willing to do the work to cook up the bot.

On Wed, Jun 6, 2018 at 12:22 PM Holden Karau <> wrote:

> Hi friends,
> Was chatting with some folks at the summit and I was wondering how people
> would feel about adding a review bot to ping folks. We already have the
> review dashboard but I was thinking we could ping folks who were the
> original authors of the code being changed whom might not be in the habit
> of looking at the review dashboard.
> Cheers,
> Holden :)
> --
> Twitter:

View raw message