spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William Wong <william1...@gmail.com>
Subject Re: Preserving cache name and storage level upon table refresh
Date Mon, 15 Apr 2019 16:21:17 GMT
Hi Sean and @gatorsmile <https://github.com/gatorsmile>,

Thanks a lot for your previous review. I updated those test (
https://github.com/apache/spark/pull/24221) accordingly. May I know if you
can help reviewing them again?

Best regards,
William



On Wed, Apr 3, 2019 at 1:03 AM William Wong <william1104@gmail.com> wrote:

> Dear Spark developers,
>
> We noticed that cache name could be changed upon table refreshing. It is
> because CatalogImpl.refreshTable would first uncached and then recache
> (lazily) without first preserving cache name (and its storage level). IMHO,
> it is not what a user would expect.
>
> I submitted a JIRA (https://issues.apache.org/jira/browse/SPARK-27248)
> and a PR (https://github.com/apache/spark/pull/24221), so that cache name
> and storage level would be preserved in table refreshing in the future.
>
> Appreciate anyone know this part well to review it further. It is my first
> PR to spark. I hope I make it right. Any comments and suggestions
> are welcome. [PS: many thanks to Attila Zsolt Piros on those style issues. ]
>
> Thanks and regards,
> William
>

Mime
View raw message