spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dongjoon Hyun <dongjoon.h...@gmail.com>
Subject Re: Exposing JIRA issue types at GitHub PRs
Date Fri, 14 Jun 2019 08:15:46 GMT
Hi, All.

JIRA and PR is ready for reviews.

https://issues.apache.org/jira/browse/SPARK-28051 (Exposing JIRA issue
component types at GitHub PRs)
https://github.com/apache/spark/pull/24871

Bests,
Dongjoon.


On Thu, Jun 13, 2019 at 10:48 AM Dongjoon Hyun <dongjoon.hyun@gmail.com>
wrote:

> Thank you for the feedbacks and requirements, Hyukjin, Reynold, Marco.
>
> Sure, we can do whatever we want.
>
> I'll wait for more feedbacks and proceed to the next steps.
>
> Bests,
> Dongjoon.
>
>
> On Wed, Jun 12, 2019 at 11:51 PM Marco Gaido <marcogaido91@gmail.com>
> wrote:
>
>> Hi Dongjoon,
>> Thanks for the proposal! I like the idea. Maybe we can extend it to
>> component too and to some jira labels such as correctness which may be
>> worth to highlight in PRs too. My only concern is that in many cases JIRAs
>> are created not very carefully so they may be incorrect at the moment of
>> the pr creation and it may be updated later: so keeping them in sync may be
>> an extra effort..
>>
>> On Thu, 13 Jun 2019, 08:09 Reynold Xin, <rxin@databricks.com> wrote:
>>
>>> Seems like a good idea. Can we test this with a component first?
>>>
>>> On Thu, Jun 13, 2019 at 6:17 AM Dongjoon Hyun <dongjoon.hyun@gmail.com>
>>> wrote:
>>>
>>>> Hi, All.
>>>>
>>>> Since we use both Apache JIRA and GitHub actively for Apache Spark
>>>> contributions, we have lots of JIRAs and PRs consequently. One specific
>>>> thing I've been longing to see is `Jira Issue Type` in GitHub.
>>>>
>>>> How about exposing JIRA issue types at GitHub PRs as GitHub `Labels`?
>>>> There are two main benefits:
>>>> 1. It helps the communication between the contributors and reviewers
>>>> with more information.
>>>>     (In some cases, some people only visit GitHub to see the PR and
>>>> commits)
>>>> 2. `Labels` is searchable. We don't need to visit Apache Jira to search
>>>> PRs to see a specific type.
>>>>     (For example, the reviewers can see and review 'BUG' PRs first by
>>>> using `is:open is:pr label:BUG`.)
>>>>
>>>> Of course, this can be done automatically without human intervention.
>>>> Since we already have GitHub Jenkins job to access JIRA/GitHub, that job
>>>> can add the labels from the beginning. If needed, I can volunteer to update
>>>> the script.
>>>>
>>>> To show the demo, I labeled several PRs manually. You can see the
>>>> result right now in Apache Spark PR page.
>>>>
>>>>   - https://github.com/apache/spark/pulls
>>>>
>>>> If you're surprised due to those manual activities, I want to apologize
>>>> for that. I hope we can take advantage of the existing GitHub features to
>>>> serve Apache Spark community in a way better than yesterday.
>>>>
>>>> How do you think about this specific suggestion?
>>>>
>>>> Bests,
>>>> Dongjoon
>>>>
>>>> PS. I saw that `Request Review` and `Assign` features are already used
>>>> for some purposes, but these feature are out of the scope in this email.
>>>>
>>>

Mime
View raw message