spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sean Owen <sro...@gmail.com>
Subject Re: Seeking committers' help to review on SS PR
Date Sat, 28 Nov 2020 03:15:33 GMT
I don't know the code well, but those look minor and straightforward. They
have reviews from the two most knowledgeable people in this area. I don't
think you need to block for 6 months after proactively seeking all likely
reviewers - I'm saying that's the resolution to this type of situation
(too).

On Fri, Nov 27, 2020 at 8:55 PM Jungtaek Lim <kabhwan.opensource@gmail.com>
wrote:

> Btw, there are two more PRs which got LGTM by a SS contributor but fail to
> get attention from committers. They're 6+ months old. Could you help
> reviewing this as well, or do you all think 6 months of time range + LGTM
> from an SS contributor is enough to go ahead?
>
> https://github.com/apache/spark/pull/27649
> https://github.com/apache/spark/pull/28363
>
> These are under 100 lines of changes per each, and not invasive.
>

Mime
View raw message