spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Imran Rashid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-4746) integration tests should be separated from faster unit tests
Date Wed, 10 Dec 2014 17:03:12 GMT

    [ https://issues.apache.org/jira/browse/SPARK-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241383#comment-14241383
] 

Imran Rashid commented on SPARK-4746:
-------------------------------------

I think this can be done two ways: (1) by moving all the integration tests into a separate
folder (eg core/src/integ-test).  I don't actually know how to make that work in sbt &
maven but I'm hoping it won't be too complicated.

or (2) we use scalatest's test tags for integration tests, so they can be skipped.

http://scalatest.org/user_guide/tagging_your_tests

test tags have the advantage that you can have multple tags, and you can group them, etc.,
so you can get more flexibility in what you choose to run.  This could be useful later eg.
we might want to tag performance tests as separate from correctness tests, etc.  We don't
need to do all that now but this would open the door for it at least.

I have some experience w/ using test tags.  If we want to use that approach, I can assign
to myself and work on a PR.

> integration tests should be separated from faster unit tests
> ------------------------------------------------------------
>
>                 Key: SPARK-4746
>                 URL: https://issues.apache.org/jira/browse/SPARK-4746
>             Project: Spark
>          Issue Type: Bug
>            Reporter: Imran Rashid
>            Priority: Trivial
>
> Currently there isn't a good way for a developer to skip the longer integration tests.
 This can slow down local development.  See http://apache-spark-developers-list.1001551.n3.nabble.com/Spurious-test-failures-testing-best-practices-td9560.html
> One option is to use scalatest's notion of test tags to tag all integration tests, so
they could easily be skipped



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message