spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-1660) Centralize the definition of property names and default values
Date Fri, 23 Jan 2015 12:50:35 GMT

    [ https://issues.apache.org/jira/browse/SPARK-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289207#comment-14289207
] 

Sean Owen commented on SPARK-1660:
----------------------------------

Can this be closed? or made specific? declaring property names as constants helps avoid typos,
for sure, but I'm not sure there is a problem of this form in the code now. It's actually
hard to know where to put this class with all the constant definitions; even Core is too heavy
a dependency for some users of the property values. Certainly if there are cases of defaults
being inconsistent that should just be fixed in its own right. Are there some?

> Centralize the definition of property names and default values
> --------------------------------------------------------------
>
>                 Key: SPARK-1660
>                 URL: https://issues.apache.org/jira/browse/SPARK-1660
>             Project: Spark
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Kousuke Saruta
>
> There are lots of multiple definition of property names and default values in the code.
> Let's consolidate and clean up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message