spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Wendell (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-1934) "this" reference escape to "selectorThread" during construction in ConnectionManager
Date Wed, 28 Jan 2015 20:45:34 GMT

     [ https://issues.apache.org/jira/browse/SPARK-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Patrick Wendell resolved SPARK-1934.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.3.0
         Assignee: Sean Owen

> "this" reference escape to "selectorThread" during construction in ConnectionManager
> ------------------------------------------------------------------------------------
>
>                 Key: SPARK-1934
>                 URL: https://issues.apache.org/jira/browse/SPARK-1934
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>            Reporter: Shixiong Zhu
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> `selectorThread` starts in the construction of `org.apache.spark.network.ConnectionManager`,
which may cause `writeRunnableStarted` and `readRunnableStarted` are uninitialized before
them are used.
> Indirectly, `BlockManager.this` also escape since it calls `new ConnectionManager(...)`
and will be used in some threads of `ConnectionManager`. Some threads may view an uninitialized
`BlockManager`.
> In summary, it's dangerous and hard to analyse the correctness of concurrency. Such escape
should be avoided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message