spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-4147) Remove log4j dependency
Date Sat, 24 Jan 2015 18:32:34 GMT

    [ https://issues.apache.org/jira/browse/SPARK-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290751#comment-14290751
] 

Sean Owen commented on SPARK-4147:
----------------------------------

[~tgpfeiffer] Yeah that's a good change, since all code hits {{Logging}} quickly. It is certainly
not the only direct use of log4j, but maybe this actually makes the issue go away for some
subset of use cases. I'll make a PR.

[~nemccarthy] I don't think it forces log4j on callers, since you can reroute calls to log4j
to slf4j. Yes it's extra plumbing. There's not another way to control log levels though, since
there is no API for it in slf4j.

> Remove log4j dependency
> -----------------------
>
>                 Key: SPARK-4147
>                 URL: https://issues.apache.org/jira/browse/SPARK-4147
>             Project: Spark
>          Issue Type: Wish
>          Components: Spark Core
>    Affects Versions: 1.1.0
>            Reporter: Tobias Pfeiffer
>
> spark-core has a hard dependency on log4j, which shouldn't be necessary since slf4j is
used. I tried to exclude slf4j-log4j12 and log4j dependencies in my sbt file.
> Excluding org.slf4j.slf4j-log4j12 works fine if logback is on the classpath. However,
removing the log4j dependency fails because in https://github.com/apache/spark/blob/v1.1.0/core/src/main/scala/org/apache/spark/Logging.scala#L121
a static method of org.apache.log4j.LogManager is accessed *even if* log4j is not in use.
> I guess removing all dependencies on log4j may be a bigger task, but it would be a great
help if the access to LogManager would be done only if log4j use was detected before. (This
is a 2-line change.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message