spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheng Lian (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-6285) Duplicated code leads to errors
Date Fri, 13 Mar 2015 09:43:38 GMT

    [ https://issues.apache.org/jira/browse/SPARK-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360147#comment-14360147
] 

Cheng Lian commented on SPARK-6285:
-----------------------------------

[~fiberit] and [~srowen], thanks for reporting this! These two classes should have been removed
in [#4116|https://github.com/apache/spark/pull/4116]. That PR wasn't associated with a JIRA
ticket and was marked as "Minor". Now in retrospect, it seems not that minor actually... Just
opened a PR to fix this.

> Duplicated code leads to errors
> -------------------------------
>
>                 Key: SPARK-6285
>                 URL: https://issues.apache.org/jira/browse/SPARK-6285
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 1.3.0
>            Reporter: Iulian Dragos
>
> The following class is duplicated inside [ParquetTestData|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTestData.scala#L39]
and [ParquetIOSuite|https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetIOSuite.scala#L44],
with exact same code and fully qualified name:
> {code}
> org.apache.spark.sql.parquet.TestGroupWriteSupport
> {code}
> The second one was introduced in [3b395e10|https://github.com/apache/spark/commit/3b395e10510782474789c9098084503f98ca4830],
but even though it mentions that `ParquetTestData` should be removed later, I couldn't find
a corresponding Jira ticket.
> This duplicate class causes the Eclipse builder to fail (since src/main and src/test
are compiled together in Eclipse, unlike Sbt).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message