spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pete Robbins (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SPARK-12470) Incorrect calculation of row size in o.a.s.catalyst.expressions.codegen.GenerateUnsafeRowJoiner
Date Mon, 21 Dec 2015 22:33:46 GMT
Pete Robbins created SPARK-12470:
------------------------------------

             Summary: Incorrect calculation of row size in o.a.s.catalyst.expressions.codegen.GenerateUnsafeRowJoiner
                 Key: SPARK-12470
                 URL: https://issues.apache.org/jira/browse/SPARK-12470
             Project: Spark
          Issue Type: Bug
    Affects Versions: 1.5.2
            Reporter: Pete Robbins
            Priority: Minor


While looking into https://issues.apache.org/jira/browse/SPARK-12319 I noticed that the row
size is incorrectly calculated.

The "sizeReduction" value is calculated in words:

   // The number of words we can reduce when we concat two rows together.
    // The only reduction comes from merging the bitset portion of the two rows, saving 1
word.
    val sizeReduction = bitset1Words + bitset2Words - outputBitsetWords

but then it is subtracted from the size of the row in bytes:

       |    out.pointTo(buf, ${schema1.size + schema2.size}, sizeInBytes - $sizeReduction);
 





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message