spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Bozarth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-10653) Remove unnecessary things from SparkEnv
Date Thu, 05 May 2016 21:26:13 GMT

    [ https://issues.apache.org/jira/browse/SPARK-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273117#comment-15273117
] 

Alex Bozarth commented on SPARK-10653:
--------------------------------------

I'm currently running tests on a fix for this and will open a PR after. I have removed blockTransferService
and sparkFilesDir and replaced the few references to them. ExecutorMemoryManager was already
removed in SPARK-10984. I also took a quick look at the other vals in the constructor and
I didn't see any other low hanging fruit to remove.

> Remove unnecessary things from SparkEnv
> ---------------------------------------
>
>                 Key: SPARK-10653
>                 URL: https://issues.apache.org/jira/browse/SPARK-10653
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 1.0.0
>            Reporter: Andrew Or
>
> As of the writing of this message, there are at least two things that can be removed
from it:
> {code}
> @DeveloperApi
> class SparkEnv (
>     val executorId: String,
>     private[spark] val rpcEnv: RpcEnv,
>     val serializer: Serializer,
>     val closureSerializer: Serializer,
>     val cacheManager: CacheManager,
>     val mapOutputTracker: MapOutputTracker,
>     val shuffleManager: ShuffleManager,
>     val broadcastManager: BroadcastManager,
>     val blockTransferService: BlockTransferService, // this one can go
>     val blockManager: BlockManager,
>     val securityManager: SecurityManager,
>     val httpFileServer: HttpFileServer,
>     val sparkFilesDir: String, // this one maybe? It's only used in 1 place.
>     val metricsSystem: MetricsSystem,
>     val shuffleMemoryManager: ShuffleMemoryManager,
>     val executorMemoryManager: ExecutorMemoryManager, // this can go
>     val outputCommitCoordinator: OutputCommitCoordinator,
>     val conf: SparkConf) extends Logging {
>   ...
> }
> {code}
> We should avoid adding to this infinite list of things in SparkEnv's constructors if
they're not needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message