spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-19567) Support some Schedulable variables immutability and access
Date Sun, 12 Feb 2017 20:31:41 GMT

    [ https://issues.apache.org/jira/browse/SPARK-19567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862956#comment-15862956
] 

Sean Owen commented on SPARK-19567:
-----------------------------------

There are probably a thousand improvements like this that we could make. If there's even a
modest argument that it would improve correctness, readability, speed, etc. I think you could
go ahead and fix up a subsection of the code. The constraint is that we couldn't really change
public APIs. Is that the case here? 

> Support some Schedulable variables immutability and access
> ----------------------------------------------------------
>
>                 Key: SPARK-19567
>                 URL: https://issues.apache.org/jira/browse/SPARK-19567
>             Project: Spark
>          Issue Type: Improvement
>          Components: Scheduler
>    Affects Versions: 2.1.0
>            Reporter: Eren Avsarogullari
>            Priority: Minor
>
> Support some Schedulable variables immutability and access
> Some Schedulable variables need refactoring for immutability and access modifiers as
follows:
> - from vars to vals(if there is no requirement): This is important to support immutability
as much as possible. 
> Sample => Pool: weight, minShare, priority, name and taskSetSchedulingAlgorithm.
> - access modifiers: Specially, vars access needs to be restricted from other parts of
codebase to prevent potential side effects. Sample: 
> Sample => TaskSetManager: tasksSuccessful, totalResultSize, calculatedTasks etc...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message