spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vasilis Vryniotis (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SPARK-19787) Different default regParam values in ALS
Date Wed, 01 Mar 2017 14:03:45 GMT

     [ https://issues.apache.org/jira/browse/SPARK-19787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vasilis Vryniotis updated SPARK-19787:
--------------------------------------
    Description: 
In the ALS method the default values of regParam do not match within the same file (lines
[224|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L224]
and [714|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L714]).
In one place we set it to 1.0 and in the other to 0.1.

We can change the one of train() method to 0.1. The method is marked with DeveloperApi so
it should not affect the users. Based on what I saw, whenever we use the particular method
we provide all parameters, so the default does not matter. Only exception is the unit-tests
on ALSSuite but the change does not break them.

This change was discussed on a separate PR and [~mlnick] [suggested|https://github.com/apache/spark/pull/17059#issuecomment-283333572]
to create a separate PR & ticket.

  was:
In the ALS method the default values of regParam do not match within the same file (lines
[224](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L224)
and [714](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L714)).
In one place we set it to 1.0 and in the other to 0.1.

We can change the one of train() method to 0.1. The method is marked with DeveloperApi so
it should not affect the users. Based on what I saw, whenever we use the particular method
we provide all parameters, so the default does not matter. Only exception is the unit-tests
on ALSSuite but the change does not break them.


> Different default regParam values in ALS
> ----------------------------------------
>
>                 Key: SPARK-19787
>                 URL: https://issues.apache.org/jira/browse/SPARK-19787
>             Project: Spark
>          Issue Type: Bug
>          Components: MLlib
>    Affects Versions: 2.0.0, 2.0.1, 2.0.2, 2.1.0
>            Reporter: Vasilis Vryniotis
>
> In the ALS method the default values of regParam do not match within the same file (lines
[224|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L224]
and [714|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L714]).
In one place we set it to 1.0 and in the other to 0.1.
> We can change the one of train() method to 0.1. The method is marked with DeveloperApi
so it should not affect the users. Based on what I saw, whenever we use the particular method
we provide all parameters, so the default does not matter. Only exception is the unit-tests
on ALSSuite but the change does not break them.
> This change was discussed on a separate PR and [~mlnick] [suggested|https://github.com/apache/spark/pull/17059#issuecomment-283333572]
to create a separate PR & ticket.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message