spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takuya Ueshin (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-25058) Use Block.isEmpty/nonEmpty to check whether the code is empty or not.
Date Thu, 09 Aug 2018 05:08:00 GMT

     [ https://issues.apache.org/jira/browse/SPARK-25058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Takuya Ueshin resolved SPARK-25058.
-----------------------------------
       Resolution: Fixed
         Assignee: Takuya Ueshin
    Fix Version/s: 2.4.0

Issue resolved by pull request 22041
https://github.com/apache/spark/pull/22041

> Use Block.isEmpty/nonEmpty to check whether the code is empty or not.
> ---------------------------------------------------------------------
>
>                 Key: SPARK-25058
>                 URL: https://issues.apache.org/jira/browse/SPARK-25058
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Takuya Ueshin
>            Assignee: Takuya Ueshin
>            Priority: Major
>             Fix For: 2.4.0
>
>
> We should use {{Block.isEmpty/nonEmpty}} instead of comparing with empty string to check
whether the code is empty or not.
> {noformat}
> [error] [warn] /.../sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala:278:
org.apache.spark.sql.catalyst.expressions.codegen.Block and String are unrelated: they will
most likely always compare unequal
> [error] [warn]       if (ev.code != "" && required.contains(attributes(i))) {
> [error] [warn] 
> [error] [warn] /.../sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala:323:
org.apache.spark.sql.catalyst.expressions.codegen.Block and String are unrelated: they will
most likely never compare equal
> [error] [warn]          |  ${buildVars.filter(_.code == "").map(v => s"${v.isNull}
= true;").mkString("\n")}
> [error] [warn] 
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message