spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Spark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-25178) Use dummy name for xxxHashMapGenerator key/value schema field
Date Wed, 22 Aug 2018 18:24:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-25178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589220#comment-16589220
] 

Apache Spark commented on SPARK-25178:
--------------------------------------

User 'kiszk' has created a pull request for this issue:
https://github.com/apache/spark/pull/22187

> Use dummy name for xxxHashMapGenerator key/value schema field
> -------------------------------------------------------------
>
>                 Key: SPARK-25178
>                 URL: https://issues.apache.org/jira/browse/SPARK-25178
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Kris Mok
>            Priority: Minor
>
> Following SPARK-18952 and SPARK-22273, this ticket proposes to change the generated field
name of the keySchema / valueSchema to a dummy name instead of using {{key.name}}.
> In previous discussion from SPARK-18952's PR [1], it was already suggested that the field
names were being used, so it's not worth capturing the strings as reference objects here.
Josh suggested merging the original fix as-is due to backportability / pickability concerns.
Now that we're coming up to a new release, this can be revisited.
> [1]: https://github.com/apache/spark/pull/16361#issuecomment-270253719



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message