From issues-return-197661-apmail-spark-issues-archive=spark.apache.org@spark.apache.org Wed Aug 1 04:39:02 2018 Return-Path: X-Original-To: apmail-spark-issues-archive@minotaur.apache.org Delivered-To: apmail-spark-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D2FA18677 for ; Wed, 1 Aug 2018 04:39:02 +0000 (UTC) Received: (qmail 37436 invoked by uid 500); 1 Aug 2018 04:39:02 -0000 Delivered-To: apmail-spark-issues-archive@spark.apache.org Received: (qmail 37395 invoked by uid 500); 1 Aug 2018 04:39:02 -0000 Mailing-List: contact issues-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@spark.apache.org Received: (qmail 37386 invoked by uid 99); 1 Aug 2018 04:39:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2018 04:39:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CFE131A20FA for ; Wed, 1 Aug 2018 04:39:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Yf2-6c9_1Edb for ; Wed, 1 Aug 2018 04:39:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0ED955F21E for ; Wed, 1 Aug 2018 04:39:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 820B8E25D4 for ; Wed, 1 Aug 2018 04:39:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 349712775E for ; Wed, 1 Aug 2018 04:39:00 +0000 (UTC) Date: Wed, 1 Aug 2018 04:39:00 +0000 (UTC) From: "Jungtaek Lim (JIRA)" To: issues@spark.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (SPARK-24311) Refactor HDFSBackedStateStoreProvider to remove duplicated logic between operations on delta file and snapshot file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SPARK-24311?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved SPARK-24311. ---------------------------------- Resolution: Won't Fix As I got feedback on [https://github.com/apache/spark/pull/21357#issuecomme= nt-409427970]=C2=A0the patch is unlikely accepted. Closing this for now. > Refactor HDFSBackedStateStoreProvider to remove duplicated logic between = operations on delta file and snapshot file > -------------------------------------------------------------------------= ------------------------------------------ > > Key: SPARK-24311 > URL: https://issues.apache.org/jira/browse/SPARK-24311 > Project: Spark > Issue Type: Improvement > Components: Structured Streaming > Affects Versions: 2.3.0 > Reporter: Jungtaek Lim > Priority: Major > > The structure of delta file and snapshot file is same, but the operations= are defined as individual methods which incurs duplicated logic between de= lta=C2=A0file and snapshot file. > We can refactor to remove=C2=A0duplicated logic=C2=A0to ensure readabilit= y, as well as guaranteeing that the structure of delta file and snapshot fi= le keeps same. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org For additional commands, e-mail: issues-help@spark.apache.org