spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wenchen Fan (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-26730) Strip redundant AssertNotNull expression for ExpressionEncoder's serializer
Date Fri, 01 Feb 2019 02:50:00 GMT

     [ https://issues.apache.org/jira/browse/SPARK-26730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Wenchen Fan resolved SPARK-26730.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 3.0.0

Issue resolved by pull request 23651
[https://github.com/apache/spark/pull/23651]

> Strip redundant AssertNotNull expression for ExpressionEncoder's serializer
> ---------------------------------------------------------------------------
>
>                 Key: SPARK-26730
>                 URL: https://issues.apache.org/jira/browse/SPARK-26730
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: wuyi
>            Priority: Major
>             Fix For: 3.0.0
>
>
> For types like Product, we've already add AssertNotNull when we construct serializer(pls
see the code below), so we could strip redundant AssertNotNull for those types. Please see
the code with the related PR for details.
>  
> {code:java}
> val fieldValue = Invoke(
> AssertNotNull(inputObject, walkedTypePath), fieldName, dataTypeFor(fieldType),
> returnNullable = !fieldType.typeSymbol.asClass.isPrimitive)
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message