spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Graves (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-28859) Remove value check of MEMORY_OFFHEAP_SIZE in declaration section
Date Wed, 09 Oct 2019 18:08:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-28859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947908#comment-16947908
] 

Thomas Graves commented on SPARK-28859:
---------------------------------------

The comment came from the pr you linked to, but was referring to the config definition and
any other usages.

If you look in config/package.scala MEMORY_OFFHEAP_SIZE check if >= 0.  Really I think
that should be >0 when its specified by the user. Need to see if that > 0 is ok in checkValue
and check other usages of it.

> Remove value check of MEMORY_OFFHEAP_SIZE in declaration section
> ----------------------------------------------------------------
>
>                 Key: SPARK-28859
>                 URL: https://issues.apache.org/jira/browse/SPARK-28859
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 3.0.0
>            Reporter: Yang Jie
>            Priority: Minor
>
> Now MEMORY_OFFHEAP_SIZE has default value 0, but It should be greater than 0 when 
> MEMORY_OFFHEAP_ENABLED is true,, should we check this condition in code?
>  
> SPARK-28577 add this check before request memory resource to Yarn 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message