spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Rosen (Jira)" <j...@apache.org>
Subject [jira] [Created] (SPARK-29310) TestMemoryManager should implement getExecutionMemoryUsageForTask()
Date Tue, 01 Oct 2019 07:12:00 GMT
Josh Rosen created SPARK-29310:
----------------------------------

             Summary: TestMemoryManager should implement getExecutionMemoryUsageForTask()
                 Key: SPARK-29310
                 URL: https://issues.apache.org/jira/browse/SPARK-29310
             Project: Spark
          Issue Type: Improvement
          Components: Tests
    Affects Versions: 3.0.0
            Reporter: Josh Rosen
            Assignee: Josh Rosen


Spark uses a {{TestMemoryManager}} class to mock out memory manager functionality in tests,
allowing test authors to exercise control over certain behaviors (e.g. to simulate OOMs).

Our tests have memory-leak detection to ensure that all allocated memory is cleaned up at
the end of each test case; this helps to guard against bugs that could cause production memory
leaks.

Unfortunately, however, this leak-detection logic is broken for tests which use {{TestMemoryManager}}
because it does not override the {{getExecutionMemoryUsageForTask()}} method which the leak-detection
mechanism needs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message