spot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brandon-edwards <>
Subject [GitHub] incubator-spot pull request #4: User domain hard coded as "intel" for DNS Su...
Date Fri, 16 Dec 2016 23:27:48 GMT
GitHub user brandon-edwards opened a pull request:

    User domain hard coded as "intel" for DNS Suspicious Connects Analysis - Issue: [SPOT-24]

    On line 67 of
the code tests the domain string variable against the string "intel" in order to determine
whether the domain should be considered to be in the users domain. For non intel solution-users
this is a problem, I will allow this string to be passed from spot.conf.

You can merge this pull request into a Git repository by running:

    $ git pull User_Domain_Designation_Fix

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
commit bc5744f6f5e81521a3905ae072177218fdd6b05c
Author: Brandon Edwards <>
Date:   2016-12-05T22:59:38Z

     Eddited DNSWordCreation.scala DomainProcessor.scala DNSSuspiciousConnectsModel.scala,
and SuspicousConnectsArgumentParser to all allow in a variable user domain designation. More
work to do in order to have this information come in from the spot.conf.

commit 41ffbc3c3744eadc7baac4633f160188bcad731a
Author: Brandon Edwards <>
Date:   2016-12-06T17:03:02Z

    Inserted lines into spot.conf and for input of user domain string.

commit d7d6ae07344a9a4308067963cb9b03e493b995d0
Author: Brandon Edwards <>
Date:   2016-12-06T22:45:38Z

    More modifications in order to pass the user domain info around to the places that are

commit f3b3652673713fd36152605c64df9a95e140e818
Author: Brandon Edwards <>
Date:   2016-12-08T00:39:18Z

    More editing on SuspiciousConnectsArgumentParser to eliminate old (dropped) arguments.

commit f7596ca8f13629e09d88a4d257ecb6f8d10f33de
Author: Brandon Edwards <>
Date:   2016-12-08T00:46:41Z

    And yet more editing of SuspiciousConnectsArgumentParser.scala to remove old argument

commit 8f0988ae205a54e3d3d67c56aa7dab7f8b5e5584
Author: Brandon Edwards <>
Date:   2016-12-08T22:52:59Z

    Updating spot branch from upstream (spot repo)
    Merge branch 'spot' of into

commit f6c2b2ba754832a3aff04baec6af791e77b53221
Author: Brandon Edwards <>
Date:   2016-12-08T22:55:12Z

    Trying to resolve conflicts by merging in an updated version of spot branch
    Merge branch 'spot' into Shouldbe_good_domain_fix

commit 55b0497bf3a6dbe87e659cadffcb70784cb9c1af
Author: Brandon Edwards <>
Date:   2016-12-09T21:56:44Z

    Changed the usderDomain input to be optional in the argument parser and changed the default
value of this armgument to be the empty string in spot.conf.

commit 13fc71863558d8d27512ca7c710fda585812a63a
Author: Brandon Edwards <>
Date:   2016-12-10T01:02:50Z

    Added a test to DomainProcessorTest.scala to insure that an empty string for userDomain
would not be taken as the legitimate user domain in the case of an empty string domain.

commit b9cc67d1ea4579781a95d86e1d34ea49cf069b68
Author: Brandon Edwards <>
Date:   2016-12-13T20:37:48Z

    Modified spot.conf to contain logic that only tries to pass the userdomain option when
the spot.conf variable USER_DOMAIN is non-empty.

commit 3bf290dd0a33368486abea1d803163bbc7cd7736
Author: Brandon Edwards <>
Date:   2016-12-14T00:21:47Z

    Changed the position of the optional parameter to be at the end of all other parameters

commit 452fca35bd33c291b88cd4a664f531db1ba7d7e2
Author: Brandon Edwards <>
Date:   2016-12-14T16:25:30Z

    Omitted an extra space after one of the jar parameter entry lines that was causing an

commit 1a0269f2e0f9a1297e1084c01b1991362f0a74ae
Author: Brandon Edwards <>
Date:   2016-12-14T16:35:14Z



If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message