spot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nate Smith <>
Subject Re: [Proposal] PR voting process changes
Date Thu, 21 Sep 2017 17:28:24 GMT

As a point of consideration it's good to highlight that in such a scenario
where a +1 is given and 48 hours to review prior to merge, any -1 should
reset the vote in my mind. Votes of such nature would have to be restricted
to committers on the project.

On Thu, Sep 21, 2017 at 10:22 AM, Nate Smith <> wrote:

> Hello,
> From my own experience and also in talking directly with a few committers
> to the project the requirement for three +1's from committers should be
> reviewed.
> My understanding is that other projects in the ASF simply require one vote
> and provide some time for review by others prior to merging (such as a
> 24-48 hour period). However more emphasis is placed on refining code in
> preparation for releases.
> As it stands today we require at least three +1's before merge, and there
> is no time requirement.
> Since we are a growing community, and the goal is to develop more code
> contributors I think it is important to bring this up for review in hopes
> that we can adopt something that allows faster iterations with a strong
> focus on polishing for future releases.
> - Nathanael

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message