sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arvind Prabhakar" <arv...@apache.org>
Subject Review Request: SQOOP-317. OracleManager should allow working with tables owned by other users.
Date Thu, 18 Aug 2011 00:15:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1579/
-----------------------------------------------------------

Review request for Sqoop, jmhsieh and Bilung Lee.


Summary
-------

Modified OracleManager implementation to use global catalog views instead of user-specific
views for metadata queries. Also introduced a test case that specifically exercises the functionality
in question. Note that if this gets committed, the Oracle test configuration would need to
be changed in order to introduce a new user that will be used by the OracleManagerTest.


This addresses bug SQOOP-317.
    https://issues.apache.org/jira/browse/SQOOP-317


Diffs
-----

  /src/java/com/cloudera/sqoop/manager/OracleManager.java 1158963 
  /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1158963 
  /src/test/com/cloudera/sqoop/manager/OracleUtils.java 1158963 

Diff: https://reviews.apache.org/r/1579/diff


Testing
-------

All unit and thirdparty tests along with some manual testing.


Thanks,

Arvind


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message