sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arvind Prabhakar" <arv...@apache.org>
Subject Re: Review Request: SQOOP-321 Support date/time columns for "--incremental append" option
Date Wed, 24 Aug 2011 03:29:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1623/#review1610
-----------------------------------------------------------


Changes look good Bilung. I do have a backward compatibility concern noted below. Other than
that, it will be good to give some examples of use of this feature in the user guide. The
more specific examples you can give, the better it would be for the users.


src/java/com/cloudera/sqoop/manager/ConnManager.java
<https://reviews.apache.org/r/1623/#comment3639>

    This may be a compatibility issue for third party connectors. It is best to leave this
method as is and introduce a new method that gets called when the check column type is not
numeric.


- Arvind


On 2011-08-22 23:20:55, Bilung Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1623/
> -----------------------------------------------------------
> 
> (Updated 2011-08-22 23:20:55)
> 
> 
> Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar.
> 
> 
> Summary
> -------
> 
> Currently, when "--incremental append" option is used, only numeric columns are supported
for check column.
> 
> 
> This addresses bug SQOOP-321.
>     https://issues.apache.org/jira/browse/SQOOP-321
> 
> 
> Diffs
> -----
> 
>   src/java/com/cloudera/sqoop/manager/ConnManager.java cea0a73 
>   src/java/com/cloudera/sqoop/manager/OracleManager.java bad45dc 
>   src/java/com/cloudera/sqoop/tool/ImportTool.java 66e60bd 
>   src/test/com/cloudera/sqoop/TestIncrementalImport.java 96d4309 
> 
> Diff: https://reviews.apache.org/r/1623/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bilung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message