sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mohammad Nour El-Din <nour.moham...@gmail.com>
Subject Re: [VOTE] Review and Commit Policy
Date Thu, 18 Aug 2011 09:29:55 GMT
On Thu, Aug 18, 2011 at 10:29 AM, Olivier Lamy <olamy@apache.org> wrote:
> Hello,
> Even if I like the idea of using reviewboard tool, something I don't
> like is to have to post the patch/diff twice to both jira and
> reviewboard (or maybe there is something I don't understand :-) ).
> I wonder how we could integrate review board with Jenkins to have an
> automatic test of provided patch.
> (@abayer heh probably need some hacking around jenkins for supporting
> other scm than only perforce)

We could think about that later, unless we have something that can
make the integration possible for the moment. If not, then we need to
use what we already have and then, later, we can think about how to
enhance it :). Agile/Iterative approach ;).

> Thanks
> --
> Olivier Lamy
> Talend : http://talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
> 2011/8/18 Arvind Prabhakar <arvind@apache.org>:
>> This is a call to vote for Review and Commit Policy for Apache Sqoop
>> project. The proposal up for vote is as follows:
>> - The committer attaches the patch s/he would like to submit to the
>> JIRA and posts a code review requests with at least one other
>> committer identified as the reviewer.
>> - If the reviewer does not respond in two days time, the committer
>> sends a note to sqoop-dev@ asking for the reviewer to prioritize the
>> review or for any other committer to volunteer for the review.
>> - If the review is still not done in the next three days, the change
>> may be committed and the JIRA resolved/closed.
>> - If the review is started, then no timeout applies and the full
>> review cycle should be followed until a reasonable version of the
>> change has been accepted. At which point it can be committed and the
>> JIRA resolved/closed.
>> The DISCUSSION thread for this topic can be found at [1].
>> Please vote:
>> +1 to agree
>> 0 no opinion
>> -1 to disagree
>> This vote is open for 72 hours starting today.
>> [1] http://markmail.org/thread/otolffxxr2b5sdqx
>> Thanks,
>> Arvind Prabhakar

- Mohammad Nour
"Life is like riding a bicycle. To keep your balance you must keep moving"
- Albert Einstein

View raw message