sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arvind Prabhakar" <arv...@apache.org>
Subject Re: Review Request: SQOOP-327 Mixed update/insert export support for OracleManager
Date Wed, 07 Sep 2011 04:33:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1717/#review1779
-----------------------------------------------------------


Changes look good. One question/suggestion below.


src/java/com/cloudera/sqoop/mapreduce/OracleUpsertOutputFormat.java
<https://reviews.apache.org/r/1717/#comment4061>

    How about extending from ExportBatchOutputFormat? That would likely work as well unless
I am missing something.


- Arvind


On 2011-09-06 18:09:15, Bilung Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1717/
> -----------------------------------------------------------
> 
> (Updated 2011-09-06 18:09:15)
> 
> 
> Review request for Sqoop, Ahmed Radwan, Arvind Prabhakar, and jmhsieh.
> 
> 
> Summary
> -------
> 
> A new option is introduced to allow update records if they exist in table already or
to insert records if they do not exist yet.
> 
> 
> This addresses bug SQOOP-327.
>     https://issues.apache.org/jira/browse/SQOOP-327
> 
> 
> Diffs
> -----
> 
>   src/docs/man/sqoop-export.txt 50052cc 
>   src/docs/user/export.txt 4401c26 
>   src/java/com/cloudera/sqoop/SqoopOptions.java d07aecc 
>   src/java/com/cloudera/sqoop/manager/ConnManager.java f5f5a4b 
>   src/java/com/cloudera/sqoop/manager/OracleManager.java 1d08c4d 
>   src/java/com/cloudera/sqoop/mapreduce/JdbcUpsertExportJob.java PRE-CREATION 
>   src/java/com/cloudera/sqoop/mapreduce/OracleUpsertOutputFormat.java PRE-CREATION 
>   src/java/com/cloudera/sqoop/mapreduce/UpdateOutputFormat.java d5339d9 
>   src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 879c7c8 
>   src/java/com/cloudera/sqoop/tool/ExportTool.java d156eeb 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 12858d7 
> 
> Diff: https://reviews.apache.org/r/1717/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bilung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message