sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arvind Prabhakar" <arv...@apache.org>
Subject Re: Review Request: SQOOP-357 Log every exception in a chain after execution failure
Date Fri, 07 Oct 2011 02:41:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2265/#review2424
-----------------------------------------------------------


Overall the changes look good. One suggestion though - would it be possible to move the logging
logic for SQLException in a Util class somewhere (perhaps a new util class called ExceptionUtils
in org.apache.sqoop). That way, in other places where we catch SQLException, we could simply
invoke this method.

- Arvind


On 2011-10-07 02:15:04, Bilung Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2265/
> -----------------------------------------------------------
> 
> (Updated 2011-10-07 02:15:04)
> 
> 
> Review request for Sqoop and Arvind Prabhakar.
> 
> 
> Summary
> -------
> 
> Currently, only the error message of the first exception in a chain will be logged.
> However, the root cause exception may be buried in the exception chain.
> To help diagnose the root cause, we need to log all error messages in the chain.
> 
> 
> This addresses bug SQOOP-357.
>     https://issues.apache.org/jira/browse/SQOOP-357
> 
> 
> Diffs
> -----
> 
>   ./src/java/com/cloudera/sqoop/mapreduce/AsyncSqlRecordWriter.java 1179036 
>   ./src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1179036 
> 
> Diff: https://reviews.apache.org/r/2265/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bilung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message