sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec" <jar...@jarcec.net>
Subject Re: Review Request: SQOOP-342: Allow user to override sqoop type mapping
Date Sat, 08 Oct 2011 07:14:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1975/
-----------------------------------------------------------

(Updated 2011-10-08 07:14:15.084689)


Review request for Sqoop and Arvind Prabhakar.


Changes
-------

Hi Arvind,
I've incorporated all your suggestions with one exception - I left Avro untouched. It's not
trivial to add this kind of support for Avro, because it seems to me that Avro is expecting
numbers and not type names. So I'll probably introduce new parameter for overriding Avro mapping
and put some code to allow user specify names that will be automatically translated into appropriate
integers.

Doing that is not that straightforward and because there is currently demand for this patch
I think that it would be better to close this issue with current functionality and add Avro
support later. I've already put validation for parameters that will rise an exception in case
that both mapping and Avro output are requested. 

What do you think?

Jarcec


Summary
-------

This is not fully featured patch yet, it's more only preview of what I have in my mind when
I created the bug and how would I image to solve it. I would like to check with community
whether this is acceptable solution and if so, I'll finish the patch.

Things that are missing and I'll add them if this way will be accepted:
* Tests
* Documentation
* Supporting for type names (so that user don't have to type the integer constants on command
line)

Any feedback will be greatly appreciated.


This addresses bug sqoop-342.
    https://issues.apache.org/jira/browse/sqoop-342


Diffs (updated)
-----

  /src/docs/man/codegen-args.txt 1180125 
  /src/docs/man/hive-args.txt 1180125 
  /src/docs/man/import-args.txt 1180125 
  /src/docs/user/codegen-args.txt 1180125 
  /src/docs/user/codegen.txt 1180125 
  /src/docs/user/hive-args.txt 1180125 
  /src/docs/user/import.txt 1180125 
  /src/java/com/cloudera/sqoop/SqoopOptions.java 1180125 
  /src/java/com/cloudera/sqoop/hive/TableDefWriter.java 1180125 
  /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1180125 
  /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1180125 
  /src/java/com/cloudera/sqoop/tool/ImportTool.java 1180125 
  /src/test/com/cloudera/sqoop/TestSqoopOptions.java 1180125 
  /src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 1180125 
  /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1180125 

Diff: https://reviews.apache.org/r/1975/diff


Testing
-------


Thanks,

Jarek


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message