sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arvind Prabhakar" <arv...@apache.org>
Subject Re: Review Request: SQOOP-371 Migrate com.cloudera.sqoop.util package to new name space
Date Mon, 24 Oct 2011 19:33:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2519/#review2800
-----------------------------------------------------------

Ship it!


+1 - looks good to me.

- Arvind


On 2011-10-22 19:36:22, Bilung Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2519/
> -----------------------------------------------------------
> 
> (Updated 2011-10-22 19:36:22)
> 
> 
> Review request for Sqoop and Arvind Prabhakar.
> 
> 
> Summary
> -------
> 
> 1. Create the new package under org.apache.sqoop namespace.
> 2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
> 3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
> 4. Deprecate classes under com.cloudera.sqoop namespace.
> 
> 
> This addresses bug SQOOP-371.
>     https://issues.apache.org/jira/browse/SQOOP-371
> 
> 
> Diffs
> -----
> 
>   ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/Executor.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/Jars.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591 
>   ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591 
>   ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION 
>   ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/2519/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bilung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message