sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: Migrate lib and io packages to new namespace.
Date Thu, 27 Oct 2011 21:22:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2564/#review2894
-----------------------------------------------------------


Thanks for the patch.  Looks good overall.  Just one comment.


/src/java/com/cloudera/sqoop/io/LobFile.java
<https://reviews.apache.org/r/2564/#comment6474>

    Need to reference to the constant in apache namespace as well here.


- Bilung


On 2011-10-25 21:37:26, Arvind Prabhakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2564/
> -----------------------------------------------------------
> 
> (Updated 2011-10-25 21:37:26)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Summary
> -------
> 
> Migrating com.cloudera.sqoop.io and com.cloudera.sqoop.lib packages to org.apache.sqoop
namespace.
> 
> 
> This addresses bug SQOOP-379.
>     https://issues.apache.org/jira/browse/SQOOP-379
> 
> 
> Diffs
> -----
> 
>   /build.xml 1188922 
>   /src/java/com/cloudera/sqoop/io/CodecMap.java 1188922 
>   /src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 1188922 
>   /src/java/com/cloudera/sqoop/io/LobFile.java 1188922 
>   /src/java/com/cloudera/sqoop/io/LobReaderCache.java 1188922 
>   /src/java/com/cloudera/sqoop/io/NamedFifo.java 1188922 
>   /src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java 1188922 
>   /src/java/com/cloudera/sqoop/io/SplittingOutputStream.java 1188922 
>   /src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/BlobRef.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/BooleanParser.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/ClobRef.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/DelimiterSet.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/FieldFormatter.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/FieldMappable.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/LobRef.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/LobSerializer.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/ProcessingException.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/RecordParser.java 1188922 
>   /src/java/com/cloudera/sqoop/lib/SqoopRecord.java 1188922 
>   /src/java/org/apache/sqoop/io/CodecMap.java PRE-CREATION 
>   /src/java/org/apache/sqoop/io/FixedLengthInputStream.java PRE-CREATION 
>   /src/java/org/apache/sqoop/io/LobFile.java PRE-CREATION 
>   /src/java/org/apache/sqoop/io/LobReaderCache.java PRE-CREATION 
>   /src/java/org/apache/sqoop/io/NamedFifo.java PRE-CREATION 
>   /src/java/org/apache/sqoop/io/SplittableBufferedWriter.java PRE-CREATION 
>   /src/java/org/apache/sqoop/io/SplittingOutputStream.java PRE-CREATION 
>   /src/java/org/apache/sqoop/io/UnsupportedCodecException.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/BigDecimalSerializer.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/BlobRef.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/BooleanParser.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/ClobRef.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/DelimiterSet.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/FieldFormatter.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/FieldMapProcessor.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/FieldMappable.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/JdbcWritableBridge.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/LargeObjectLoader.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/LobRef.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/LobSerializer.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/ProcessingException.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/RecordParser.java PRE-CREATION 
>   /src/java/org/apache/sqoop/lib/SqoopRecord.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/2564/diff
> 
> 
> Testing
> -------
> 
> Ran all unit and thirdparty tests. There are new findbugs warnings because the same class
name is used by the newly introduced classes - but this is expected since we want the migration
of existing code to be done with minimal effort.
> 
> 
> Thanks,
> 
> Arvind
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message