sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-386) Namespace migration cleanup
Date Wed, 02 Nov 2011 04:32:33 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141912#comment-13141912
] 

jiraposter@reviews.apache.org commented on SQOOP-386:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2668/#review3007
-----------------------------------------------------------

Ship it!


+1

Changes look good Bilung. Please attach the patch to the JIRA when you get a chance.

- Arvind


On 2011-11-02 01:42:46, Bilung Lee wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2668/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-02 01:42:46)
bq.  
bq.  
bq.  Review request for Arvind Prabhakar.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Patch for SQOOP-386.
bq.  
bq.  
bq.  This addresses bug SQOOP-386.
bq.      https://issues.apache.org/jira/browse/SQOOP-386
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ./NOTICE.txt 1187139 
bq.    ./src/docs/dev/SqoopDevGuide.txt 1196401 
bq.    ./src/docs/dev/api-reference.txt 1187844 
bq.    ./src/docs/dev/compiling.txt 1187844 
bq.    ./src/docs/dev/intro.txt 1187844 
bq.    ./src/docs/dev/preface.txt 1187844 
bq.    ./src/docs/man/codegen-args.txt 1187844 
bq.    ./src/docs/man/common-args.txt 1187844 
bq.    ./src/docs/man/hbase-args.txt 1187844 
bq.    ./src/docs/man/hive-args.txt 1187844 
bq.    ./src/docs/man/import-args.txt 1187844 
bq.    ./src/docs/man/input-args.txt 1187844 
bq.    ./src/docs/man/output-args.txt 1187844 
bq.    ./src/docs/sip/INDEX.txt 1187844 
bq.    ./src/docs/sip/README.txt 1187844 
bq.    ./src/docs/sip/sip-1.txt 1187844 
bq.    ./src/docs/sip/sip-2.txt 1187844 
bq.    ./src/docs/sip/sip-3.txt 1187844 
bq.    ./src/docs/sip/sip-4.txt 1187844 
bq.    ./src/docs/sip/sip-6.txt 1187844 
bq.    ./src/docs/user/SqoopUserGuide.txt 1187844 
bq.    ./src/docs/user/basics.txt 1187844 
bq.    ./src/docs/user/codegen-args.txt 1187844 
bq.    ./src/docs/user/codegen-purpose.txt 1187844 
bq.    ./src/docs/user/codegen.txt 1187844 
bq.    ./src/docs/user/common-args.txt 1187844 
bq.    ./src/docs/user/compatibility.txt 1187844 
bq.    ./src/docs/user/connecting.txt 1187844 
bq.    ./src/docs/user/controlling-input-format.txt 1187844 
bq.    ./src/docs/user/controlling-output-format.txt 1187844 
bq.    ./src/docs/user/create-hive-table-purpose.txt 1187844 
bq.    ./src/docs/user/create-hive-table.txt 1187844 
bq.    ./src/docs/user/eval-purpose.txt 1187844 
bq.    ./src/docs/user/eval.txt 1187844 
bq.    ./src/docs/user/export-purpose.txt 1187844 
bq.    ./src/docs/user/export.txt 1187844 
bq.    ./src/docs/user/hbase-args.txt 1187844 
bq.    ./src/docs/user/hbase.txt 1187844 
bq.    ./src/docs/user/help.txt 1187844 
bq.    ./src/docs/user/hive-args.txt 1187844 
bq.    ./src/docs/user/hive-notes.txt 1187844 
bq.    ./src/docs/user/hive.txt 1187844 
bq.    ./src/docs/user/import-all-tables-purpose.txt 1187844 
bq.    ./src/docs/user/import-all-tables.txt 1187844 
bq.    ./src/docs/user/import-purpose.txt 1187844 
bq.    ./src/docs/user/import.txt 1187844 
bq.    ./src/docs/user/input-args.txt 1187844 
bq.    ./src/docs/user/input-formatting-args.txt 1187844 
bq.    ./src/docs/user/input-formatting.txt 1187844 
bq.    ./src/docs/user/intro.txt 1187844 
bq.    ./src/docs/user/job-purpose.txt 1187844 
bq.    ./src/docs/user/list-databases.txt 1187844 
bq.    ./src/docs/user/list-tables.txt 1187844 
bq.    ./src/docs/user/merge-purpose.txt 1187844 
bq.    ./src/docs/user/metastore-purpose.txt 1187844 
bq.    ./src/docs/user/output-args.txt 1187844 
bq.    ./src/docs/user/output-formatting-args.txt 1187844 
bq.    ./src/docs/user/output-formatting.txt 1187844 
bq.    ./src/docs/user/preface.txt 1187844 
bq.    ./src/docs/user/saved-jobs.txt 1187844 
bq.    ./src/docs/user/support.txt 1187844 
bq.    ./src/docs/user/tools.txt 1187844 
bq.    ./src/docs/user/troubleshooting.txt 1187844 
bq.    ./src/docs/user/version.txt 1187844 
bq.    ./src/docs/web/breadcrumbs.xsl 1187844 
bq.    ./src/docs/web/docbook.css 1187844 
bq.    ./src/docs/web/footer.xsl 1187844 
bq.    ./src/docs/web/header.xsl 1187844 
bq.    ./src/docs/web/html.xsl 1187844 
bq.    ./src/docs/web/index.txt 1187844 
bq.    ./src/java/com/cloudera/sqoop/ConnFactory.java 1187591 
bq.    ./src/java/com/cloudera/sqoop/Sqoop.java 1187591 
bq.    ./src/java/com/cloudera/sqoop/SqoopOptions.java 1187591 
bq.    ./src/java/com/cloudera/sqoop/cli/RelatedOptions.java 1195865 
bq.    ./src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 1195691 
bq.    ./src/java/com/cloudera/sqoop/io/LobFile.java 1190438 
bq.    ./src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 1196291 
bq.    ./src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1190670 
bq.    ./src/java/com/cloudera/sqoop/mapreduce/DelegatingOutputFormat.java 1190670 
bq.    ./src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java 1190670 
bq.    ./src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1190670 
bq.    ./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1190670 
bq.    ./src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1195852 
bq.    ./src/java/com/cloudera/sqoop/tool/SqoopTool.java 1196194 
bq.    ./src/java/com/cloudera/sqoop/util/TaskId.java 1188941 
bq.    ./src/java/org/apache/sqoop/ConnFactory.java PRE-CREATION 
bq.    ./src/java/org/apache/sqoop/Sqoop.java PRE-CREATION 
bq.    ./src/java/org/apache/sqoop/SqoopOptions.java PRE-CREATION 
bq.    ./src/java/org/apache/sqoop/lib/ClobRef.java 1196332 
bq.    ./src/java/org/apache/sqoop/lib/DelimiterSet.java 1196332 
bq.    ./src/java/org/apache/sqoop/manager/PostgresqlManager.java 1196332 
bq.    ./src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java 1196332 
bq.    ./src/java/org/apache/sqoop/mapreduce/MySQLDumpInputFormat.java 1196332 
bq.    ./src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java 1196332 
bq.    ./src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1196332 
bq.    ./src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java 1196332 
bq.    ./src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java 1196332 
bq.    ./src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java 1196332 
bq.    ./src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1196332 
bq.    ./src/perftest/ExportStressTest.java 1187139 
bq.    ./src/perftest/ExtConnFactoryTest.java 1187139 
bq.    ./src/perftest/ExtFactory.java 1187139 
bq.    ./src/perftest/LobFilePerfTest.java 1187139 
bq.    ./src/perftest/LobFileStressTest.java 1187139 
bq.    ./src/test/com/cloudera/sqoop/AllTests.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/SmokeTests.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestAllTables.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestAppendUtils.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestAvroExport.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestAvroImport.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestCompression.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestConnFactory.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestExport.java 1195790 
bq.    ./src/test/com/cloudera/sqoop/TestExportUpdate.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestIncrementalImport.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestMerge.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestMultiCols.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestMultiMaps.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestQuery.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestSplitBy.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestSqoopOptions.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestTargetDir.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/TestWhere.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/ThirdPartyTests.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/hbase/TestHBaseUtil.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/io/TestCodecMap.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/io/TestLobFile.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/io/TestNamedFifo.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/io/TestSplittableBufferedWriter.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/lib/TestBlobRef.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/lib/TestBooleanParser.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/lib/TestClobRef.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/lib/TestFieldFormatter.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/lib/TestRecordParser.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/OracleUtils.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 1196291 
bq.    ./src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1190533

bq.    ./src/test/com/cloudera/sqoop/manager/TestHsqldbManager.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/manager/TestSqlManager.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/mapreduce/MapreduceTests.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1190533

bq.    ./src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1195805 
bq.    ./src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1195805 
bq.    ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/CommonArgs.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/DirUtil.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/ExplicitSetMapper.java 1195790 
bq.    ./src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/HsqldbTestServer.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/InjectableConnManager.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/InjectableManagerFactory.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/MockObjectFactory.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/MockResultSet.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/testutil/ReparseMapper.java 1195788 
bq.    ./src/test/com/cloudera/sqoop/testutil/SeqFileReader.java 1190533 
bq.    ./src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1195805 
bq.    ./src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java 1190533 
bq.    ./src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java 1196332 
bq.  
bq.  Diff: https://reviews.apache.org/r/2668/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  All test cases
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Bilung
bq.  
bq.


                
> Namespace migration cleanup
> ---------------------------
>
>                 Key: SQOOP-386
>                 URL: https://issues.apache.org/jira/browse/SQOOP-386
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Bilung Lee
>            Assignee: Bilung Lee
>
> 1. Migrate those classes directly under sqoop package.
> 2. Make sure checkstyle runs clean.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message