sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-421: User guide should state that when using --direct, hbase params get ignored
Date Mon, 09 Jan 2012 18:12:41 GMT


> On 2012-01-09 17:51:17, Alex Newman wrote:
> > I'm going to assume you compiled and looked at the doc. If so lgtm!

Yup, your assumption is correct, I built the documentation and it seems fine. I've uploaded
to JIRA updated version without the extra line, so feel free to commit it.


> On 2012-01-09 17:51:17, Alex Newman wrote:
> > /src/docs/user/hbase.txt, line 27
> > <https://reviews.apache.org/r/3430/diff/1/?file=67157#file67157line27>
> >
> >     Not exactly sure if this line matters

Thank you for pointing this empty line out. It's ugly artifact that I left there accidentally
when I was moving NOTE block around the text for best position. 


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3430/#review4268
-----------------------------------------------------------


On 2012-01-08 16:43:49, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3430/
> -----------------------------------------------------------
> 
> (Updated 2012-01-08 16:43:49)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Alex Newman.
> 
> 
> Summary
> -------
> 
> I've just added note that --direct parameter is incompatible with HBase import.
> 
> 
> This addresses bug SQOOP-421.
>     https://issues.apache.org/jira/browse/SQOOP-421
> 
> 
> Diffs
> -----
> 
>   /src/docs/user/hbase.txt 1228879 
> 
> Diff: https://reviews.apache.org/r/3430/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message