sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: hadoop 1.0.0 compatible build
Date Thu, 12 Jan 2012 21:04:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3412/#review4334
-----------------------------------------------------------


Thanks for the patch, Karthik!  Some suggestions below.


http://svn.apache.org/repos/asf/incubator/sqoop/trunk/build.xml
<https://reviews.apache.org/r/3412/#comment9757>

    I would suggest "100" instead of "10x".



http://svn.apache.org/repos/asf/incubator/sqoop/trunk/build.xml
<https://reviews.apache.org/r/3412/#comment9765>

    "Can only be 20, 23, or 100".



http://svn.apache.org/repos/asf/incubator/sqoop/trunk/ivy.xml
<https://reviews.apache.org/r/3412/#comment9760>

    name="hadoop100"



http://svn.apache.org/repos/asf/incubator/sqoop/trunk/ivy.xml
<https://reviews.apache.org/r/3412/#comment9762>

    name="hadoop100test"



http://svn.apache.org/repos/asf/incubator/sqoop/trunk/ivy.xml
<https://reviews.apache.org/r/3412/#comment9763>

    conf="hadoop100->default"



http://svn.apache.org/repos/asf/incubator/sqoop/trunk/ivy.xml
<https://reviews.apache.org/r/3412/#comment9764>

    conf="hadoop100test->default"


- Bilung


On 2012-01-06 05:37:15, Karthik K wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3412/
> -----------------------------------------------------------
> 
> (Updated 2012-01-06 05:37:15)
> 
> 
> Review request for Sqoop.
> 
> 
> Summary
> -------
> 
> Have a patch to build with hadoop 1.0.0 release as well. 
> 
> To specify the right hadoop version, override the following properties file. 
> 
> $HOME/build.properties:
> ------------------
> hadoopversion=10x
> 
> This will build a sqoop client that can talk to hdfs/m-r 1.0.0 .
> 
> 
> This addresses bug SQOOP-420.
>     https://issues.apache.org/jira/browse/SQOOP-420
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/incubator/sqoop/trunk/build.xml 1227959 
>   http://svn.apache.org/repos/asf/incubator/sqoop/trunk/ivy.xml 1227959 
> 
> Diff: https://reviews.apache.org/r/3412/diff
> 
> 
> Testing
> -------
> 
> Yes. Tested with a sample hadoop 1.0.0 cluster with 3 nodes. 
> 
> 
> Thanks,
> 
> Karthik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message