sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-411) Precompile Pattern for replacement of Hive delimiters
Date Tue, 03 Jan 2012 17:10:40 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178826#comment-13178826
] 

jiraposter@reviews.apache.org commented on SQOOP-411:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3357/#review4178
-----------------------------------------------------------

Ship it!


- Alex


On 2012-01-03 16:00:41, Lars Francke wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3357/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-03 16:00:41)
bq.  
bq.  
bq.  Review request for Sqoop.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Introduces a precompiled Pattern for the Hive delimiter chars
bq.  
bq.  
bq.  This addresses bug SQOOP-411.
bq.      https://issues.apache.org/jira/browse/SQOOP-411
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/java/org/apache/sqoop/lib/FieldFormatter.java 1226835 
bq.  
bq.  Diff: https://reviews.apache.org/r/3357/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  All tests succeed
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Lars
bq.  
bq.


                
> Precompile Pattern for replacement of Hive delimiters
> -----------------------------------------------------
>
>                 Key: SQOOP-411
>                 URL: https://issues.apache.org/jira/browse/SQOOP-411
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Priority: Minor
>         Attachments: SQOOP-411.1.patch, SQOOP-411.2.patch
>
>
> The method {{FieldFormatter.hiveStringReplaceDelims}} is potentially called millions
of times so precompiling the replacement pattern makes sense.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message