sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-450) Direct MySQL import can fail when using mysqldump version 5.1.14 or above.
Date Thu, 01 Mar 2012 04:40:09 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219797#comment-13219797
] 

jiraposter@reviews.apache.org commented on SQOOP-450:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4121/
-----------------------------------------------------------

Review request for Sqoop.


Summary
-------

See Jira description for problem summary. The fix was to add the logic in the mapper sinks
to parse out and ignore empty lines and those that begin with a comment marker.


This addresses bug SQOOP-450.
    https://issues.apache.org/jira/browse/SQOOP-450


Diffs
-----

  /src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1295369 

Diff: https://reviews.apache.org/r/4121/diff


Testing
-------

Ran DirectMySQLTest and MySQLAuthTest using mysqldump version 5.5.19 going against server
version 5.1.61 where this problem is reproducible. Also tested against a system with MySQL
version 5.5.20 where this problem was originally not reproducible.

Apart from this, ran the customary unit tests and third party tests.


Thanks,

Arvind


                
> Direct MySQL import can fail when using mysqldump version 5.1.14 or above.
> --------------------------------------------------------------------------
>
>                 Key: SQOOP-450
>                 URL: https://issues.apache.org/jira/browse/SQOOP-450
>             Project: Sqoop
>          Issue Type: Bug
>          Components: connectors/mysql
>    Affects Versions: 1.4.1-incubating
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>
> When using direct MySQL connector, the expected output of the {{mysqldump}} command is
individual records as follows:
> {noformat}
> INSERT INTO `EMPLOYEES_MYSQL_1` VALUES (2,'Bob',100,'2009-04-20',400,'sales');
> INSERT INTO `EMPLOYEES_MYSQL_1` VALUES (3,'Fred',4000000000,'2009-01-23',15,'marketing');
> {noformat}
> However, if the client version of MySQL being used is 5.1.14 or above, the output may
have a warning header as follows if the tablespaces are not defined:
> {noformat}
> --
> -- Not dumping tablespaces as no INFORMATION_SCHEMA.FILES table on this server
> --
> INSERT INTO `EMPLOYEES_MYSQL_1` VALUES (2,'Bob',100,'2009-04-20',400,'sales');
> INSERT INTO `EMPLOYEES_MYSQL_1` VALUES (3,'Fred',4000000000,'2009-01-23',15,'marketing');
> {noformat}
> Notice that it contains an empty line and other lines that begin with the comment marker
{{\-\-}}. 
> This causes the MySQLDumpMapper to error out due to unexpected format of the records
being read.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message