sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-451 Add format string to select query for Oracle DB
Date Thu, 08 Mar 2012 01:52:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4235/
-----------------------------------------------------------

(Updated 2012-03-08 01:52:58.860527)


Review request for Sqoop, Arvind Prabhakar and Bilung Lee.


Changes
-------

Move fixupColumnTypes() from ClassWriter to OracleManager (i.e. no longer changing ClassWriter).
It seems to fit better in OracleManager since that is Oracle-specific.


Summary
-------

Oracle compatibility tests are fragile since the output format of timestamp from the DB varies
depending on versions. To test different versions effectively, we should make the output more
deterministic.

This patch is not going to be submitted unless a new option is added to Sqoop so that new
behaviors happen only if that option is enabled. I am posting my patch only to collect feedback.


This addresses bug SQOOP-451.
    https://issues.apache.org/jira/browse/SQOOP-451


Diffs (updated)
-----

  ./src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1297783 
  ./src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1297783 
  ./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1297783 
  ./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1297783 
  ./src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1297783 
  ./src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1297783 
  ./src/java/org/apache/sqoop/manager/OracleManager.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/MySQLDumpImportJob.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1297783 
  ./src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1297783 
  ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1297783 
  ./src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1297783 
  ./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1297783 

Diff: https://reviews.apache.org/r/4235/diff


Testing
-------

ant test
ant test -Dthirdparty=true

Note that all the Oracle-specific methods in OracleCompatTest are removed since the same methods
in ManagerCompatTest can be used as any other DBs.


Thanks,

Cheolsoo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message