sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Review Request: SQOOP-459 Remove redundant steps in compatibility tests: verifyReadback() method
Date Fri, 09 Mar 2012 01:46:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/
-----------------------------------------------------------

Review request for Sqoop and Bilung Lee.


Summary
-------

Several tests including ManagerCompatTest do the following:

1) Tests insert data
2) Compare output from the db against inserted values
3) Run Sqoop import jobs
4) Compare output read from seq files against inserted values

Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are
fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.

Since there is little value to gain from these tests while they cause compatibility problems,
it would be better to remove them.


This addresses bug SQOOP-459.
    https://issues.apache.org/jira/browse/SQOOP-459


Diffs
-----

  ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661 
  ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661 
  ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661 
  ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661 
  ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661 
  ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661 

Diff: https://reviews.apache.org/r/4266/diff


Testing
-------


Thanks,

Cheolsoo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message