sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-459) Remove redundant steps in compatibility tests: verifyReadback() method
Date Fri, 09 Mar 2012 19:38:58 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226374#comment-13226374
] 

jiraposter@reviews.apache.org commented on SQOOP-459:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/
-----------------------------------------------------------

(Updated 2012-03-09 19:38:14.027866)


Review request for Sqoop and Bilung Lee.


Summary
-------

Several tests including ManagerCompatTest do the following:

1) Tests insert data
2) Compare output from the db against inserted values
3) Run Sqoop import jobs
4) Compare output read from seq files against inserted values

Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are
fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.

Since there is little value to gain from these tests while they cause compatibility problems,
it would be better to remove them.


This addresses bug SQOOP-459.
    https://issues.apache.org/jira/browse/SQOOP-459


Diffs
-----

  ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661 
  ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661 
  ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661 
  ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661 
  ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661 
  ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661 

Diff: https://reviews.apache.org/r/4266/diff


Testing (updated)
-------

Ran 
ant test
ant test -Dthirdparty
ant checkstyle


Thanks,

Cheolsoo


                
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
>                 Key: SQOOP-459
>                 URL: https://issues.apache.org/jira/browse/SQOOP-459
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>            Priority: Minor
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests
are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems,
it would be better to remove them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message