sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (SQOOP-456) Generated Java class does not distinguish date and timestamp in Oracle DB
Date Wed, 14 Mar 2012 18:34:40 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229473#comment-13229473
] 

Cheolsoo Park edited comment on SQOOP-456 at 3/14/12 6:33 PM:
--------------------------------------------------------------

Hi Arvind,

Thanks for your comment. I think that we would need to introduce a new option something like
--mapDateToTimestamp. In fact, this is the property that Oracle provides for this particular
problem. By default, we could set --mapDatetoTimestamp to true so that backward incompatibility
wouldn't be introduced.
                
      was (Author: cheolsoo):
    Hi Arvind,

Thanks for your comment. I think that we would need to introduce a new option something like
"--mapDateToTimestamp". In fact, this is the property that Oracle provides for this particular
problem. By default, we could set "--mapDatetoTimestamp" to true so that backward incompatibility
wouldn't be introduced.
                  
> Generated Java class does not distinguish date and timestamp in Oracle DB 
> --------------------------------------------------------------------------
>
>                 Key: SQOOP-456
>                 URL: https://issues.apache.org/jira/browse/SQOOP-456
>             Project: Sqoop
>          Issue Type: Bug
>          Components: codegen
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>            Priority: Minor
>
> In genereated Java class, both date and timestamp are considered as timestamps. For examples,
the following getter method is generated for a date column:
> {code:xml} 
> public void readFields(ResultSet __dbResults) throws SQLException {
>   this.__cur_result_set = __dbResults;
>   this.DATA_COL0 = JdbcWritableBridge.readTimestamp(1, __dbResults);
> }
> {code}
> This happens because both date and timestamp is labeled as Types.TIMESTAMP by ConnManager.
The fix seems straightforward. In ClassWriter, the new method getColTypeNamesForTable introduced
by Bilung at SQOOP-352 should replace getColTypes(). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message