sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-416) Allow code-generation arguments with Avro imports
Date Mon, 05 Mar 2012 09:59:59 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222246#comment-13222246
] 

jiraposter@reviews.apache.org commented on SQOOP-416:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4161/
-----------------------------------------------------------

(Updated 2012-03-05 09:58:09.819401)


Review request for Sqoop and Bilung Lee.


Changes
-------

Hi Bilung, 

Could you please review this diff.

Thanks,
Kyryl


Summary
-------

This is pretty trivial patch, it just introduces new variables for the name and namespace
in Avro schema and initializes them to the values passed in the options in the manner similar
to ClassWriter.


This addresses bug SQOOP-416.
    https://issues.apache.org/jira/browse/SQOOP-416


Diffs
-----

  ./src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 1296327 

Diff: https://reviews.apache.org/r/4161/diff


Testing
-------

Import and export of Avro data files from/to SQL table.


Thanks,

Kyryl


                
> Allow code-generation arguments with Avro imports
> -------------------------------------------------
>
>                 Key: SQOOP-416
>                 URL: https://issues.apache.org/jira/browse/SQOOP-416
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: codegen
>    Affects Versions: 1.4.2-incubating
>            Reporter: Michael Haeusler
>            Assignee: Kyryl Bilokurov
>              Labels: avro
>             Fix For: 1.4.2-incubating
>
>         Attachments: SQOOP-416.patch
>
>
> If you use --as-avrodatafile, sqoop will automatically generate an avro schema and store
it in the header of the avro files. You can easily extract and use that auto-generated schema
(e.g., with avro-tools getschema, avro-tools compile). It would be a great improvement, if
you could customize the name and namespace of the generated record type in this schema with
the already existing arguments --package-name and/or --class-name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message