sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-451) Add format string to select query for Oracle DB
Date Mon, 05 Mar 2012 03:31:09 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222153#comment-13222153
] 

jiraposter@reviews.apache.org commented on SQOOP-451:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4172/
-----------------------------------------------------------

Review request for Sqoop and Bilung Lee.


Summary
-------

Oracle compatibility tests are fragile since the output format of timestamp from the DB varies
depending on versions. To test different versions effectively, we should make the output more
deterministic.

The changes include:
1) Add format mask to the select query.
2) Update OracleCompatTest accordingly.

Note that date and timestamp are not distinguishable by the Oracle JDBC driver, so the same
format is applied to date output as timestamp. Therefore, the testDate methods in OracleCompatTest
expect timestamp output.


This addresses bug SQOOP-451.
    https://issues.apache.org/jira/browse/SQOOP-451


Diffs
-----

  ./src/java/org/apache/sqoop/manager/OracleManager.java 1296761 
  ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1296761 

Diff: https://reviews.apache.org/r/4172/diff


Testing
-------

ant test
ant test -Dthirdparty=true


Thanks,

Cheolsoo


                
> Add format string to select query for Oracle DB
> -----------------------------------------------
>
>                 Key: SQOOP-451
>                 URL: https://issues.apache.org/jira/browse/SQOOP-451
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>            Priority: Minor
>
> Oracle compatibility tests are fragile since the output format of timestamp from the
DB varies depending on versions. To test different versions effectively, we should make the
output more deterministic.
> This issue was originally raised by SQOOP-449, and using regular expressions in compatibility
tests was suggested. But after discussion with Arvind and Bilung, we decided to add a format
string for the date type to the select query for the Oracle DB so that the output format can
be consistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message