sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: import tool for mysql direct mode reports wrong record number
Date Fri, 04 May 2012 05:47:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/#review7546
-----------------------------------------------------------


Thank you very much for your patch. It looks good, but there are two minor coding convention
issues. If you run "ant checkstyle", you will see the following errors that I commented inline.
Would you mind fixing them and updating the patch?


./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java
<https://reviews.apache.org/r/4988/#comment16716>

    This line is longer than 80 chars.



./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java
<https://reviews.apache.org/r/4988/#comment16715>

    Please remove a tab char here.


- Cheolsoo


On 2012-05-04 01:02:58, nemon lou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4988/
> -----------------------------------------------------------
> 
> (Updated 2012-05-04 01:02:58)
> 
> 
> Review request for Sqoop, Jarek Cecho and Cheolsoo Park.
> 
> 
> Summary
> -------
> 
> I simply change the way the MySQLDumpMapper writes contents.
> May be there are other ways to fix it.Please let me know,thank you!
> 
> 
> This addresses bug SQOOP-482.
>     https://issues.apache.org/jira/browse/SQOOP-482
> 
> 
> Diffs
> -----
> 
>   ./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889 
> 
> Diff: https://reviews.apache.org/r/4988/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nemon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message