sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: import tool for mysql direct mode reports wrong record number
Date Fri, 04 May 2012 18:49:04 GMT


> On 2012-05-04 18:36:37, Cheolsoo Park wrote:
> > Nemon's fix seems to be right to me. The write() method should be called only once
per record. I also verified that his patch addresses the problem.
> > 
> > @Nemon
> > I am no commiter, so I cannot commit your patch. But you've got my vote!

@Kate
To be clear, I am not disagreeing with you. I am just talking about Nemon's diff file on reviewboard,
and the patch on the jire has to be uploaded.

Hope that nobody misinterprets my comment. :-)


- Cheolsoo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4988/#review7580
-----------------------------------------------------------


On 2012-05-04 07:33:48, nemon lou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4988/
> -----------------------------------------------------------
> 
> (Updated 2012-05-04 07:33:48)
> 
> 
> Review request for Sqoop, Jarek Cecho and Cheolsoo Park.
> 
> 
> Summary
> -------
> 
> I simply change the way the MySQLDumpMapper writes contents.
> May be there are other ways to fix it.Please let me know,thank you!
> 
> 
> This addresses bug SQOOP-482.
>     https://issues.apache.org/jira/browse/SQOOP-482
> 
> 
> Diffs
> -----
> 
>   ./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1332889 
> 
> Diff: https://reviews.apache.org/r/4988/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nemon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message