sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-476 If table name is a qualified name, Sqoop import fails in DB2
Date Tue, 15 May 2012 22:28:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4674/#review7917
-----------------------------------------------------------


Thanks for the patch!  It looks good overall.  One comment though.  It seems that two DB2
record readers are 
provided, but only one of them is actually used by the Db2Manager and is tested by the test
case.  Unless the 
generic JDBC manager also works, there is probably no need for the other record reader.

- Bilung


On 2012-04-07 00:30:40, Cheolsoo Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4674/
> -----------------------------------------------------------
> 
> (Updated 2012-04-07 00:30:40)
> 
> 
> Review request for Sqoop.
> 
> 
> Summary
> -------
> 
> During the import job, Sqoop uses the following select query:
> 
> SELECT <column names> FROM <table name> AS <table name>
> 
> This causes a SQL syntax error for DB2 if table name has a dot "." in it.
> 
> 
> The changes include:
> 
> 1) Create DB2-specific DBInputFormat/DBRecordReader + DataDrivenDBInputFormat. Note that
DataDrivenDBRecordReader is not subclassed since DB2-specific logic is implemented directly
in its getSelectQuery() method.
> 
> 2) Add a unit test that imports data from a table that has a qualified name.
> 
> 
> This addresses bug SQOOP-476.
>     https://issues.apache.org/jira/browse/SQOOP-476
> 
> 
> Diffs
> -----
> 
>   /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 1310644 
>   /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1310644 
>   /src/java/org/apache/sqoop/mapreduce/db/Db2DBRecordReader.java PRE-CREATION 
>   /src/java/org/apache/sqoop/mapreduce/db/Db2DataDrivenDBInputFormat.java PRE-CREATION

>   /src/java/org/apache/sqoop/mapreduce/db/Db2DataDrivenDBRecordReader.java PRE-CREATION

>   /src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java 1310644 
>   /src/java/org/apache/sqoop/manager/Db2Manager.java 1310644 
> 
> Diff: https://reviews.apache.org/r/4674/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cheolsoo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message