sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-480 MS SQL server connector is incompatible with Sqoop-1.4
Date Sun, 27 May 2012 19:54:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4972/
-----------------------------------------------------------

(Updated 2012-05-27 19:54:47.874627)


Review request for Sqoop.


Summary
-------

Sqoop-1.4.* is incompatible with Microsoft SQL server connector due to the namespace migration
from com.cloudera to org.apache.

The changes include:
1) Add a wrapper method setConnManager(com.cloudera.sqoop.manager.ConnManager) to ImportJobContext.
2) Enhance SQL server manager test so that it can be used with Microsoft connector as well.


This addresses bug SQOOP-480.
    https://issues.apache.org/jira/browse/SQOOP-480


Diffs
-----

  /build.xml 1333179 
  /src/java/com/cloudera/sqoop/manager/ImportJobContext.java 1333179 
  /src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1333179 

Diff: https://reviews.apache.org/r/4972/diff


Testing (updated)
-------

1) Ran 'ant test -Dtestcase=SQLServerManagerImportManualTest' with both built-in SQL connector
and Microsoft connector.
2) Ran 'ant test', 'ant test -Dthirdparty=true', and 'ant checkstyle'.


Thanks,

Cheolsoo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message