sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-495) Support for parameter substitution in the client shell.
Date Thu, 28 Jun 2012 18:12:44 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403317#comment-13403317
] 

Bilung Lee commented on SQOOP-495:
----------------------------------

Some suggestions:
- How about have a method (eg. "List resolveVariables(List args)") in SqoopCommand to return
a list of arguments with variables resolved?  Then you can invoke this method at the beginning
of the execute method within each subclass of SqoopCommand before the resolved arguments are
passed down to each function of the command subclass.
- The code only considers the variable in the form of "$variable".  It would be better to
allow the variable to be specified as "${variable}".  The variable may also appear as a substring,
such as "sqoop_$version" and "sqoop_${version}".
- You may want to check out what and how the build-in "println" supports.

                
> Support for parameter substitution in the client shell.
> -------------------------------------------------------
>
>                 Key: SQOOP-495
>                 URL: https://issues.apache.org/jira/browse/SQOOP-495
>             Project: Sqoop
>          Issue Type: Task
>            Reporter: Arvind Prabhakar
>            Assignee: Vasanth kumar RJ
>             Fix For: 2.0.0
>
>         Attachments: SQOOP-495.patch
>
>
> For instance the user could specify set foo = bar, following which every reference to
$foo will be replaced with bar.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message