sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bilung Lee" <bleeapa...@gmail.com>
Subject Re: Review Request: SQOOP-436: The --verbose option should enable verbose logging for MapReduce jobs as well
Date Mon, 18 Jun 2012 21:45:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5346/#review8356
-----------------------------------------------------------

Ship it!


Look good to me.

- Bilung Lee


On June 17, 2012, 5:55 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5346/
> -----------------------------------------------------------
> 
> (Updated June 17, 2012, 5:55 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I took rather intrusive but "expendable" way of implementing this feature. Some notes:
> 
> * I've put verbose property to the SqoopOption class - one side effect (intentional)
is that this parameter will be preserved for stored jobs
> * I've created new method propagateOptionsToJob to JobBase class that will propagate
all interesting properties to mapreduce job (so far only verbose)
> * I've created new abstract mapper SqoopMapper that is meant to be parent for all other
mappers for common behavior
> * I've put verbose propagation to SqoopMapper.setup() method
> 
> 
> This addresses bug SQOOP-436.
>     https://issues.apache.org/jira/browse/SQOOP-436
> 
> 
> Diffs
> -----
> 
>   /src/java/org/apache/sqoop/SqoopOptions.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/AutoProgressMapper.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/JobBase.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/MergeJob.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/MySQLExportMapper.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/MySQLTextExportMapper.java 1348224 
>   /src/java/org/apache/sqoop/mapreduce/SqoopMapper.java PRE-CREATION 
>   /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1348224 
>   /src/java/org/apache/sqoop/util/LoggingUtils.java 1348224 
> 
> Diff: https://reviews.apache.org/r/5346/diff/
> 
> 
> Testing
> -------
> 
> * ant test -Dhadoopversion={20,100,23}
> * Live on CDH3
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message